PB 572 b1: IDE Formdesigner display problem setting parent

Post bugs related to the IDE here
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

PB 572 b1: IDE Formdesigner display problem setting parent

Post by Kurzer »

PB 572 b1 x64 / Windows 7 x64 SP1 classic design

IDE / formdesigner: There is a small display problem in the assignment dialog for setting a parent object. At least for the german version of PB.

Image

Greetings
Kurzer
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

I have adjusted the size of the gadgets and the window.
Under Linux, it looks good for me now. Unfortunately I can't test it under Windows.

Before the fix:
Image

After the fix:
Image

PR on GitHub: https://github.com/fantaisie-software/purebasic/pull/50
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Kurzer »

PB 5.72 b2 x64:

It looks better now, but have much free space to the left.
Also the height of the comboxboxes is to big. Maybe its caused by the DPI adjusting within the FormDesigner? My desktopscale is set to 125%.

Image
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

I think it is better to always use the Dialog-Lib when it comes to cross-platform GUI creation.
In the next days I will create the window using the Dialog-Lib and post the code here for testing.
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

How it looks now under my Linux:
Image


Here is the code for testing. I hope the window always looks good now.

Code: Select all

Runtime Enumeration Window
  #WINDOW_Form_Parent
EndEnumeration

Runtime Enumeration Gadget
  #GADGET_Form_Parent_Select
  #GADGET_Form_Parent_SelectItem
  #GADGET_Form_Parent_Cancel
  #GADGET_Form_Parent_OK
EndEnumeration

XML$ = "<?xml version='1.0' encoding='UTF-8'?>" +
"<dialogs>" +
"  <window flags='#PB_Window_SystemMenu | #PB_Window_ScreenCentered' text='Übergeordnet' id='#WINDOW_Form_Parent'>" +
"    <vbox spacing='10'>" +
"      <empty/>" +
"      <gridbox colspacing='15' rowspacing='15' columns='4'>" +
"        <empty/>" +
"        <text text='Übergeordnet' flags='#PB_Text_Right'/>" +
"        <combobox height='22' width='250' id='#GADGET_Form_Parent_Select'/>" +
"        <empty/>" +
"        <empty/>" +
"        <text text='Übergeordnetes Element' flags='#PB_Text_Right'/>" +
"        <combobox height='22' width='250' id='#GADGET_Form_Parent_SelectItem'/>" +
"        <empty/>" +
"      </gridbox>" +
"      <empty/>" +
"      <hbox>" +
"        <empty/>" +
"        <button text='Abbruch' id='#GADGET_Form_Parent_Cancel'/>" +
"        <button text='OK' id='#GADGET_Form_Parent_OK'/>" +
"        <empty/>" +
"      </hbox>" +
"      <empty/>" +
"    </vbox>" +
"  </window>" +
"</dialogs>"

If ParseXML(0, XML$) And XMLStatus(0) = #PB_XML_Success
  
  If CreateDialog(0) And OpenXMLDialog(0, 0, "")
    
    For i = 0 To 2
      AddGadgetItem(#GADGET_Form_Parent_Select, -1, "Select_" + i)
      AddGadgetItem(#GADGET_Form_Parent_SelectItem, -1, "SelectItem_" + i)
    Next
    
    Repeat
      Event = WaitWindowEvent()
    Until Event = #PB_Event_CloseWindow
    
  Else
    Debug "Dialog error: " + DialogError(0)
  EndIf
Else
  Debug "XML error: " + XMLError(0) + " (Line: " + XMLErrorLine(0) + ")"
EndIf
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Kurzer »

Sorry Sicro,
I have unfortunately only seen your PN today.
The dialogue looks very good on my system. Image

Image

Kurzer
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Kurzer »

In the current beta 3, the dialogue unfortunately looks worse again.

There are no line breaks in the labels, but the combo boxes are too high again on my 125% scaled system and also the left border to the fixed frame is too wide.

Image

According to the beta 3 announcement this bug should be fixed:
- Fix display errors in window '#WINDOW_Form_Parent' of the FormDesigner (Sicro) https://github.com/fantaisie-software/purebasic/pull/50
Greetings,
"Shorty"
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

kurzer wrote:In the current beta 3, the dialogue unfortunately looks worse again.
I have not yet found the time to integrate the Dialog-Lib variant. Tomorrow I will have time for it.
kurzer wrote:According to the beta 3 announcement this bug should be fixed:
- Fix display errors in window '#WINDOW_Form_Parent' of the FormDesigner (Sicro) https://github.com/fantaisie-software/purebasic/pull/50
The mentioned pull request on GitHub is old and has already been integrated in Beta 2.
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Kurzer »

Sicro wrote:The mentioned pull request on GitHub is old and has already been integrated in Beta 2.
Oh okay, thank you for clarify this. :)
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

I have now integrated the changes and created a new pull request:
https://github.com/fantaisie-software/purebasic/pull/83
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
User avatar
Kurzer
Enthusiast
Enthusiast
Posts: 589
Joined: Sun Jun 11, 2006 12:07 am
Location: Near Hamburg

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Kurzer »

Wow, that was fast. Image
Thank you very much for your contribution, Sicro.

By the way: Do you know if the proposal on GitHub to make the PureBasic IDE independent from the necessary C compilations is already being worked on?
I haven't followed it up.

Stay well!
Kurzer
PB 5.73 x64, OS: Windows 7 Pro x64, Desktopscaling: 125%, CPU: I7 6500, RAM: 16 GB, GPU: Intel Graphics HD 520, User age: 53y
"Happiness is a pet." | "Never run a changing system!"
User avatar
Sicro
Enthusiast
Enthusiast
Posts: 440
Joined: Wed Jun 25, 2014 5:25 pm
Location: Germany

Re: PB 572 b1: IDE Formdesigner display problem setting pare

Post by Sicro »

kurzer wrote:By the way: Do you know if the proposal on GitHub to make the PureBasic IDE independent from the necessary C compilations is already being worked on?
I haven't followed it up.
The work is in progress. More off-topic via PN, please.
Image
Why OpenSource should have a license :: DarkColor-Scheme for PureBasic
PureBasic-CodeArchiv-Rebirth: Git-Repository / Download – Any help is welcome!
Manjaro Xfce x64 (Main system) :: Windows 7 x64 (VirtualBox) :: Newest PureBasic version
Post Reply